Port memory printing on OpenBSD #493
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucic71
commented
Jul 21, 2022
lucic71
commented
- Split print_memory into get_memory_info which is platform dependent and print_formatted_memory which is platform independent
- Created struct print_mem_info that keeps memory counters which will be passed between get_memory_info and print_formatted_memory
- Used UVM subsystem to get memory counters on OpenBSD
- Added the requirements in README
- src/print_cpu_usage.c does not compile on OpenBSD because of the conditional definition of __OpenBSD__
This function will be called from all architectures
|
I still need to find a way to get buffers, cached and shared memory. If you have any idea how to do that it would be much appreciated. |
|
@stapelberg is this repo still active? |
|
Yes, this is still active, but I don’t really have time to answer development questions, sorry. I can try to review and merge your PR once you let me know it’s ready (it sounded like it wasn’t ready currently). |
added 3 commits
August 11, 2022 19:04
…1/i3status into feature/print_mem_openbsd
|
@stapelberg, it's ready for reviewing! |
Thanks, this looks reasonable on first glance. Can you format your code with clang-format to make the CI pass? Have you run the tests yet to ensure they pass, too? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.